search

chaynHQ / bloom-backend

Code for the backend / API of the Bloom service
https://bloom.chayn.co/
MIT License
17 stars 29 forks source link

Added session feedback controller and service with tests for error an… #520

Closed ckirby19 closed 1 month ago

ckirby19 commented 1 month ago

…d success cases

Issue link / number:

396

What changes did you make?

Why did you make the changes?

As requested on the ticket

Did you run tests?

Yes, I added new tests for the success and error cases in the service, and these tests were successful. I was also able to hit the endpoint with a POST request using postman and have a new session feedback entity be added to the session feedback database table

ckirby19 commented 1 month ago

@eleanorreem

eleanorreem commented 1 month ago

@ckirby19 Thanks for all your comments and I agree with them all. I should have highlighted the new type patterns in the ticket. Apologies. We are only just starting to clean up the backend as it hasn't been a priority! I have one small request to remove the ISessionFeedback which you highlighted. Otherwise, this is good to go.

eleanorreem commented 1 month ago

Brilliant - thanks @ckirby19 ⭐