search

chaynHQ / bloom-frontend

Code for the for the frontend of the Bloom service.
https://bloom.chayn.co/
MIT License
28 stars 44 forks source link

App Router Migration - Root Layout #1083

Open boodland opened 1 month ago

boodland commented 1 month ago

Sub issue of #702

App router uses a Root layout which is defined at the top of the app directory and applies to all routes. We need to migrate the contents of _app.tsx and _document.tsx to the root layout so they are applied for the app route.

Due to the complexity of the _app.tsx and _document.tsx files, the migration will be done according to the following steps as discussed in #1064:

  1. Creating the app directory and basic root layout with public testing page #1085
  2. Add Newrelic configuration #1086
  3. Add GoogleTagManager script #1117
  4. Add Rollbar script #1118
  5. Add OpenGraph Metadata #1120
  6. Add ErrorBoundary component #1121
  7. Add Material UI configuration #1122
  8. Add Analytics configuration #1123

Step one will be the parent PR/branch where the rest of the steps will be created from and merged to, once all the steps are completed and merged the PR/branch can be merged within dev branch.

Store Provider, i18n, Shell layout, Crisp script, AuthGuard and pages migration will be tackled in another parent PR as discussed in #1064 due to conflict with pages router and/or dependencies on i18n.

Until all pages are migrated and _app.tsx and _document.tsx files are removed any changes in any of the logic migrated to the app router needs to be changed accordingly for the app router version as well.

boodland commented 1 month ago

@kyleecodes, @eleanorreem or @annarhughes could you assign it to me please? Mentioning all of you so you are all aware of the state of the task.

github-actions[bot] commented 1 month ago

Thank you @boodland you have been assigned this issue! Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨

Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you! Learn more about Chayn here and explore our projects. 🌸