chaynHQ / bloom-frontend

Code for the for the frontend of the Bloom service.
https://bloom.chayn.co/
MIT License
31 stars 47 forks source link

International Leave this site options #898

Closed anmol-fzr closed 6 months ago

anmol-fzr commented 6 months ago

Issue :

Issue number: 888 Issue link: https://github.com/chaynHQ/bloom-frontend/issues/888

What changes did you make?

Added International to Leave this site options, now wikipedia and google links open respective to user's current language

Why did you make the changes?

This feature was obvious to have and also had an issue on the repo

Did you run tests?

I ran tests

vercel[bot] commented 6 months ago

@anmol-fzr is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 4:19pm
eleanorreem commented 6 months ago

Hi @anmol-fzr, this looks great from an initial look. As per our Contributor Guidelines, to accept your PR, you need to claim an issue. I can't seem to tag you without you commenting on the issue. This helps us keep track and document open-source contributions. 😄 Can you comment on the issue and then I can properly reviewand authorise the workflow 🎉

anmol-fzr commented 6 months ago

@eleanorreem Hopefully this PR is ready to be merged. Merge this if possible if not please inform so that i can make suitable changes

eleanorreem commented 6 months ago

Hey @anmol-fzr, Thanks for your contribution! this PR is failing to build unfortunately. The error I get looks like the screen shot below. Running yarn build and running the yarn lint will ensure you don't encounter these errors. The error comes from the use of double quotes where single should be used. Let me know if you have any questions. Thanks again!

Screenshot 2024-05-11 at 17 00 48
anmol-fzr commented 6 months ago

@eleanorreem I have fixed the Linting Error you mentioned while building this project i also encountered error about "@mui/system" library i didn't changed any other file as this library is used in the code on the official repo, assuming this won't cause errors on build.

eleanorreem commented 6 months ago

Thanks for this! All worked well ⭐