search

chaynHQ / soulmedicine

Soul Medicine a multilingual digital service designed to deliver critical safety information and supportive messaging in bite-sized pieces.
https://soulmedicine.io
MIT License
37 stars 9 forks source link

Migrate CI from Travis to GitHub Actions #305

Closed tarebyte closed 1 year ago

tarebyte commented 1 year ago

Closes https://github.com/chaynHQ/soulmedicine/issues/281

Summary

This PR creates a new GitHub Actions workflow ci.yml which runs all of the same checks as Travis when a Pull Request is opened or when commits are pushed to master.

I wasn't sure whether Actions would run on this PR so I opened it first on my own fork to demonstrate how it works: https://github.com/tarebyte/soulmedicine/pull/2.

Other changes

I was having issues running gem install erb_lint -v 0.1.3 in CI due to a rubocop-ast dependency issue. To get around it, I've updated all rubocop* dependencies to the latest supported by Ruby 2.5.8.

I didn't make any actual code changes, but I did have to add a few rubocop:disable comments to appease the linter.

and request reviews from the team

cc @swetha-charles or @eleanorreem for review per the ticket's request.

swetha-charles commented 1 year ago

Thanks for this both!

We're currently running at quite low capacity so will be able to give feedback in a few weeks. Thank you for bearing with us.

eleanorreem commented 1 year ago

Hey, this looks great! I managed to find some time this evening to have a look. Thank you so much ⭐. I can merge and remove Travis as a requirement.