search

chaynHQ / soulmedicine

Soul Medicine a multilingual digital service designed to deliver critical safety information and supportive messaging in bite-sized pieces.
https://soulmedicine.io
MIT License
37 stars 9 forks source link

Use ActionMailer::MailDeliveryJob for sending parameterized and normal mail. #349

Closed tarebyte closed 1 year ago

tarebyte commented 1 year ago

From the Rails framework upgrade file:

The default delivery jobs (ActionMailer::Parameterized::DeliveryJob, ActionMailer::DeliveryJob),
will be removed in Rails 6.1. This setting is not backwards compatible with earlier Rails versions.
If you send mail in the background, job workers need to have a copy of
MailDeliveryJob to ensure all delivery jobs are processed properly.
Make sure your entire app is migrated and stable on 6.0 before using this setting.

We do not enqueue emails to be sent in the background. We call a single cron job and send all of our emails in the 'foreground'

https://github.com/chaynHQ/soulmedicine/blob/e3cf7e4f69cb4c0cd13efecc1854b1993f88a0ea/app/workers/subscriptions_worker.rb#L7

So this change shouldn't have any consequences for us.