search

chaz23 / buddhism-in-color

https://buddhism-in-color.vercel.app
MIT License
0 stars 0 forks source link

Add missing IDs to the DPPN-SC #3

Open chaz23 opened 2 years ago

chaz23 commented 2 years ago

Add IDs to entries in the DPPN-SC that are missing IDs. As mentioned in #2, the id should be included within the <dfn> tag. Do not leave trailing whitespace at the end of the ID string. Also the ID should be the same as the name of the person (i.e exactly the same as the text within the <dfn> tag).

Eg: <dfn>Nigaṇṭha Nāṭaputta</dfn> should be amended to:

<dfn id='Nigaṇṭha Nāṭaputta'>Nigaṇṭha Nāṭaputta</dfn>

chaz23 commented 2 years ago

Another problem I've come across is that come IDs seem to be inside the <dt> tag instead of the <dfn> tag. Eg: mahamoggallana.

Should we go for consistency and move the IDs into the <dfn> tag? Perhaps I should open this as a separate issue.

EDIT: opened as #5

chaz23 commented 2 years ago

@thesunshade don't work on this just yet. I'm working on a notebook that'll make it easier for you to do this.

thesunshade commented 2 years ago

I'm assuming the notebook you gave me is the one I need to use for this? https://observablehq.com/@chaz/improving-the-dppn-sc

chaz23 commented 2 years ago

Correct! Also disregard my initial comment about how the IDs should be the same as the name.

thesunshade commented 2 years ago
thesunshade commented 2 years ago

PR submitted: https://github.com/suttacentral/sc-data/pull/132

thesunshade commented 2 years ago

@chaz23 you should run the tests again to make sure that I didn't miss any.

thesunshade commented 2 years ago

OK, I trying to remember everything that needs to be done here.

Am I correct that these folks missing ids are also missing entries? If that is the case, then creating entries for them is going to take some time. Part of the reason some of these don't have entries is because they didn't have entries in the DPPN.

chaz23 commented 2 years ago

Bhagu has two entries. I believe the one in MN is bhagu2 but you should double check.

There seem to be 4 suttas with Bhagu. I think that the ones in MN68 and MN128 are bhagu2 and the ones in MN95 and MN99 are bhagu1.

chaz23 commented 2 years ago

Am I correct that these folks missing ids are also missing entries?

Yes that is correct...

thesunshade commented 2 years ago

Would it be workable If I created a new json file with the new entries as a temporary measure? Then you would be able to move forward with things and I wouldn't have to worry about having everything be so perfect that it could be merged with the official file on SC-data.

I'm guessing that tacking them on to the end of the main dictionary file in your repository wouldn't be a problem. But maybe that's not how you are working. Let me know if this all makes sense.

I definitely want any updates we do to be added in to the real file, I'm just seeing how tricky this task is going to be.

chaz23 commented 2 years ago

Yep a temporary file, but with the same structure as the SC-DPPN would be fine. And then later when you merge the two I can update my code, no problem. :)