improved readability and reduced redundancy

chbergmann / OpticsWorkbench

GNU Lesser General Public License v3.0

69 stars 23 forks source link

improved readability and reduced redundancy #15

Closed wohltat closed 2 years ago

lgtm-com[bot] commented 2 years ago

This pull request introduces 5 alerts when merging d999cdc1f720816bf6ba2d9cbff69eb97bee5b48 into 18fd74d6e7ee98426049fb3cea8a11b5f182997f - view on LGTM.com

new alerts:

5 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 27ad7c73c74d44347c706097e39dfa89507e38ee into 18fd74d6e7ee98426049fb3cea8a11b5f182997f - view on LGTM.com

new alerts:

2 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging df112c9ce7163066adc6776842422ec5027b78c1 into 18fd74d6e7ee98426049fb3cea8a11b5f182997f - view on LGTM.com

new alerts:

2 for Unused import

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 7492a9a317883775996a93dd4ea61246078609fd into 18fd74d6e7ee98426049fb3cea8a11b5f182997f - view on LGTM.com

new alerts:

2 for Unused import

chbergmann commented 2 years ago

I merged too fast. When I start FreeCAD, I get this error: 7:43:35 During initialization the error "cannot import name 'isOpticalObject' from partially initialized module 'OpticsWorkbench' (most likely due to a circular import) (/home/christi/.FreeCAD/Mod/OpticsWorkbench/OpticsWorkbench.py)" occurred in /home/christi/.FreeCAD/Mod/OpticsWorkbench/InitGui.py 17:43:35 Please look into the log file for further information

wohltat commented 2 years ago

Ah sorry. I missed to test a FreeCAD restart.

wohltat commented 2 years ago

easiest fix is to replace from OpticsWorkbench import isOpticalObject, getSceneBoundBox with from OpticsWorkbench import * in Ray.py

That way we can also get rid of the doCommands.