Bug fix of spherical ray not showing correctly when not a origin of file.

chbergmann / OpticsWorkbench

GNU Lesser General Public License v3.0

69 stars 23 forks source link

Bug fix of spherical ray not showing correctly when not a origin of file. #26

Closed szzer closed 2 years ago

szzer commented 2 years ago

The previous modification of the spherical ray contains an error, the rays do not remain evenly spaced when the position of the ray is not at the origin of the file.

By changing the way the vector is stored (removing pl.multvec) this problem is solved. Now the spherical ray can be positioned freely in space.

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 2ea14ff3fef6303c50c552a9e70e39820ca3abda into 617d33e9c2d545ef83e0e0de7f89179adb343fe3 - view on LGTM.com

new alerts:

1 for Except block handles 'BaseException'
1 for Variable defined multiple times

szzer commented 2 years ago

I made some more mistakes, therefore i closed the pullrequest