chbergmann / OpticsWorkbench

GNU Lesser General Public License v3.0
69 stars 23 forks source link

Enable a cone shaped ray, to get more detail for simulation a directional light source (a led for example). #30

Closed szzer closed 2 years ago

szzer commented 2 years ago

Added cone angle to spherical ray, this to increase the ray density in case of testing directional point light sources (like leds).

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 1f9a9faebc6ea74044ededb6a65401301b91348c into ae0faf9c07816bc39ff8da894cc9c31a9abd211c - view on LGTM.com

new alerts:

szzer commented 2 years ago

I am testing lightguides with a led as the light source. To increase the beam desnisty and therefore get a more accurate representation of the light trajectory I wanted to have a light source which radiates only in the direction of the led elumination direction. This to reduce computing time, while increasing resultion at the desired viewing direction.

I therefore added a Cone angle parameter to the beam. This parameter, by default set to 360 degrees creates a section of the spherical ray. For example if the cone angle is set to 90 degrees, the light source will project rays in a 90 degree cone. If the cone angle is set to 360degrees default) the original sperical beam.

I hope this can be added to the OpticsWorkbench and does not conflict with existing code.

szzer commented 2 years ago

Left the new cone feature, a cone ray with a angle of 90 degrees, right a normal spherical ray (cone angle 360 degrees): Image of cone vs spherical ray