known 0.9.5 code issues at sourceforge

chcg / NPP_HexEdit

Notepad++ Plugin Hexedit

825 stars 156 forks source link

known 0.9.5 code issues at sourceforge #3

Open chcg opened 6 years ago

chcg commented 6 years ago

See https://sourceforge.net/p/npp-plugins/discussion/670932/thread/ba91fc4d/

issue with cloned view still happens, seems F11 is not necessary, just switching the focus multiple times seems to cause a cyclic call sequence leading to various nullpointer/memory issues
see also https://github.com/notepad-plus-plus/notepad-plus-plus/issues/924 and https://sourceforge.net/p/npp-plugins/discussion/670932/thread/39af4cb1/#c106 on .nfo files, seems to be no longer reproducible
https://sourceforge.net/p/npp-plugins/bugs/search/?q=labels:%22HexEditor%22
https://sourceforge.net/p/npp-plugins/bugs/297/
HexEdit doesn't keep the current encoding (e.g. UTF-8 -> Hex -> Ascii instead of UTF-8)

draven691 commented 5 years ago

One file content is : 0x30 0x00 0x02 0x30 when copy all content to other page,result is 0x30 0x20 0x02 0x30 please see this bug

KnIfER commented 4 years ago

HexEdit doesn't keep the current encoding

Meaning .. ?

chcg commented 4 years ago

@KnIfER Switch from N++ view with encoding UTF-8 -> Hexview -> N++ and then the encoding is no longer UTF-8, but ANSI. See encoding menu or statusline.

KnIfER commented 3 years ago

issue with cloned view still happens

the old plugin uses vector to record all opened file for each editor( left and right), which is is unnecessary and error-prone.

I turned it in to a map.

There are plenty of bugs in the old impl. Editors flash heavely during doc-switching, F11 & F12 crash npp in the x64 mode, and redundant calls into SystemUpdate make it even worse when you are comparing left & right docs.

Just use std::map and it will save our lives……

KnIfER commented 3 years ago

https://sourceforge.net/p/npp-plugins/bugs/297/

( Incorrect doc switching to hex mode )

The cause of the bug is that when npp opens new files, it notify HexEditor of the events ( NPPN_FILEOPENED ) before switching to the newly opened file.