search

chcg / NPP_HexEdit

Notepad++ Plugin Hexedit
825 stars 156 forks source link

Fix crash bug on Notepad++ v7.9 #37

Closed donho closed 3 years ago

donho commented 3 years ago

In Notepad++ v7.9, the shorcut of command IDM_EDIT_INS_TAB has been removed, whereas the function GetShortCuts() expected a shortcut from this command. This fix makes it work on 2 cases (with or without shorcut).

Fix #36

donho commented 3 years ago

CodeQL / Analyze (pull_request) Failing after 1m — Analyze

@chcg I have no idea about the error, could you enlight me what's the problem?

chcg commented 3 years ago

CodeQL / Analyze (pull_request) Failing after 1m — Analyze

@chcg I have no idea about the error, could you enlight me what's the problem?

Started to test https://github.com/github/codeql, not yet configured to work.

donho commented 3 years ago

@chcg OK. Thank you for the reply. So could you merge the fix and release a new version of HexEdit please?

Also, why not point HexEdit in PluginList (https://github.com/notepad-plus-plus/nppPluginList) to the releases here ?

donho commented 3 years ago

@chcg Sorry for the bothering: I can see this PR is marked as Merged with info chcg merged 1 commit into chcg:master from donho:patch-1 4 hours ago, however when I check in the master, nothing has been changed. I cannot see either the fix in the commit history... Could you check if this PR is committed into master please?

chcg commented 3 years ago

@donho Seems the merge got lost by some of my commit I think. I will correct that again.

donho commented 3 years ago

OK. No need to get my branch back. Please commit it directly - just use pSc = _tcsstr(text, _T("\t")); instead of pSc = &(_tcsstr(text, _T("\t")))[1]; BTW, could you do a release with both 32/64 bit and point HedEdit in nppPluginList to your release? I will do 7.9 RC2 soon to include the newest nppPluginList so if users complain about the problem of HexEdit in v7.9, we can just tell them to update the latest HexEdit by using PluginAdmin.

chcg commented 3 years ago

@donho

donho commented 3 years ago

@chcg

Thank you very much!