search

chcg / NPP_HexEdit

Notepad++ Plugin Hexedit
821 stars 156 forks source link

Creates empty 'Compare' subfolder even when no compares have been performed #63

Closed Gitoffthelawn closed 2 years ago

Gitoffthelawn commented 2 years ago

I'm not sure if this is a bug or a feature, but HexEdit (v0.9.11) creates an empty Compare subfolder in the extension's folder, even when no compare has ever been performed.

Obviously, not a big deal, but could be indicative of a bug or unintended behaviour, so I thought I would take a moment to mention it.

chcg commented 2 years ago

See #10, so it is intended behaviour.

Gitoffthelawn commented 2 years ago

Thanks. Would it be reasonable to move the 

if (::PathFileExists(configPath) == FALSE)

block into the code section that gets called when a compare is actually performed?

Because user data is written to that folder, it would be better practice to write to %TEMP% instead of a subfolder of Notepad++'s executable files. I can create a separate issue for that, or perhaps #10 could be reopened.

chcg commented 2 years ago

@Gitoffthelawn Most likely it could be moved to https://github.com/chcg/NPP_HexEdit/blob/8f930a24336ac5a04cf60d5fadb21c3dc80c1adf/HexEditor/src/UserDlg/CompareDialog.h#L40 or the doDialog(), but what is the advantage of this? I think that just makes sense together with using %TEMP%.