chchch / upama

A PHP library for comparing two or more Sanskrit TEI XML files and generating an apparatus with variants
GNU General Public License v2.0
10 stars 1 forks source link

a certain collation won't go #58

Closed wujastyk closed 1 year ago

wujastyk commented 1 year ago

When I try to collate

Like this, I get this error. I can't track down the reason:

image

chchch commented 1 year ago

Looking at the pagesource for the provisional edition, it looks like there might be some non-printing character at the beginning of the file (see the red dot below): image

wujastyk commented 1 year ago

I found and fixed those spurious chars before <TEI. Weird - they didn't show up in any of my usual editors, and I had to use tweak, a hex editor, to see and delete them.

Unfortunately, though, the problem persists.

chchch commented 1 year ago

Hi Dominik,

This seems to be a somewhat obscure bug... the system didn't expect two <listWit> elements. In provisional-edition_sutrasthana-32-end, if you just merge the two <listWit> elements, it should work.

wujastyk commented 1 year ago

I've merged the listwits , but still not quite solved.

https://github.com/chchch/upama/assets/762246/54708dd3-efd8-459a-80da-56458339444e

chchch commented 1 year ago

It looks like there's still two... this line:

 <listWit>
                    <witness xml:id="MN">The <title>Mādhavanidāna</title>, <abbr type="siglum"
                            >MN</abbr>
                        <idno type="siglum">Mādhavanidāna</idno></witness>
                </listWit>

                <listWit>
                    <witness xml:id="NAK_1-1146">MS Kathmandu NAK 1-1146 <abbr type="siglum"
                            >1-1146</abbr>
                        <idno type="siglum">MS NAK 1-1146</idno> A paper manuscript in Devanāgarī.
                        67 ff. Filmed as reel no A 224-9. Covers 1.8.3 - 1.44.24 of the Sūtrasthāna.
                    </witness>
                </listWit>

should be:

                 <listWit>
                    <witness xml:id="MN">The <title>Mādhavanidāna</title>, <abbr type="siglum"
                            >MN</abbr>
                        <idno type="siglum">Mādhavanidāna</idno></witness>
                    <witness xml:id="NAK_1-1146">MS Kathmandu NAK 1-1146 <abbr type="siglum"
                            >1-1146</abbr>
                        <idno type="siglum">MS NAK 1-1146</idno> A paper manuscript in Devanāgarī.
                        67 ff. Filmed as reel no A 224-9. Covers 1.8.3 - 1.44.24 of the Sūtrasthāna.
                    </witness>
                </listWit>
wujastyk commented 1 year ago

Drat, I was editing the wrong file (1-31, not 32-end, as I should have). Fixed and fine now. Apologies for messing up.