chdb-io / chdb-node

Native NodeJS bindings for chDB, an in-process SQL OLAP Engine powered by ClickHouse
https://chdb.io
Apache License 2.0
32 stars 3 forks source link

When no DB used we get: Code: 57. DB::Exception: Directory for table data data/default/testtable/ already exists. (TABLE_ALREADY_EXISTS) #18

Open ceckoslab opened 2 months ago

ceckoslab commented 2 months ago

I noticed that in the following conditions I get when I run the example script for second time:

Code: 57. DB::Exception: Directory for table data data/default/testtable/ already exists. (TABLE_ALREADY_EXISTS)

Repro:

const { query, Session } = require("chdb");

var ret;

// Test standalone query
ret = query("SELECT version(), 'Hello chDB', chdb()", "CSV");
console.log("Standalone Query Result:", ret);

// Test session query
// Create a new session instance
const session = new Session("./dir_for_table_already_exists");

session.query("CREATE TABLE IF NOT EXISTS testtable (id UInt32) ENGINE = MergeTree() ORDER BY id;");

I usually create a new DB and use the new DB but not everyone would be doing the same and could reach the same problem.

System info:

Apple M2 Pro macOS 14.5 (23F79) Node v20.9.0

  "dependencies": {
    "chdb": "^1.2.1"
  },
auxten commented 2 months ago

This is because new Session("./dir_for_table_already_exists") create session in the same dir. After create the new table testtable you didn't call session.cleanup(). So, the second time you use the same dir as the session dir. testtable already exists.

You can also avoid this by new Session() which will create the session in random tmp dir.

ceckoslab commented 2 months ago

I see @auxten

My intention is to have the inserted created tables & data available between sessions but I think that session.cleanup() will wipe out all the data:

  // Cleanup method to delete the temporary directory
  cleanup() {
    rmSync(this.path, { recursive: true }); // Replaced rmdirSync with rmSync
  }

I suppose that my use case is a bit different ... probably the usual CHDB user often starts CHDB, queries directly some data structure (CSV, JSON ...) or inserts data in CHDB that is not required when a new session get's started.

auxten commented 2 months ago

Thanks, I understand. Currently, chDB session implementation is a little tricky. Like I explained here: https://github.com/orgs/chdb-io/discussions/196#discussioncomment-8406116 Here is the plan: https://github.com/chdb-io/chdb/issues/197#issuecomment-2327976725