chdb-io / chdb

chDB is an in-process OLAP SQL Engine 🚀 powered by ClickHouse
https://clickhouse.com/docs/en/chdb
Apache License 2.0
2.03k stars 72 forks source link

Allow path in dbapi connect #176

Closed nevinpuri closed 6 months ago

nevinpuri commented 9 months ago

Just as you can pass a path argument to the dbapi.connect() function (enabling persistency). This will allow similar functionality as the Session api already provides, but using the dbapi.

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added path parameter to dbapi

Documentation entry for user-facing changes

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

nevinpuri commented 9 months ago

Don't merge yet, I just realized this change isn't fully working

nevinpuri commented 9 months ago

I've updated all the code. Should work but I haven't tested.

auxten commented 8 months ago

Please add tests for your modification. Also, there is a CLA need to sign.

nevinpuri commented 6 months ago

@auxten I have added a test. It all should work now 👍

auxten commented 6 months ago

Fixing some test issue organizations-2000000.zip link expired. Just use organizations-500000.zip