chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

deps: update poetry to 1.1.8 #724

Closed jbergstroem closed 2 years ago

jbergstroem commented 2 years ago

This bumps the pinned installation of poetry for building containers as well as setting up CI.

netlify[bot] commented 2 years ago

👷 Deploy request for kodiak-dashboard-staging pending review. Visit the deploys page to approve it

🔨 Explore the source changes: 2194048d5ab33f6d3cd58ac8a02910b3266b5058

netlify[bot] commented 2 years ago

👷 Deploy request for kodiak-docs pending review. Visit the deploys page to approve it

🔨 Explore the source changes: 2194048d5ab33f6d3cd58ac8a02910b3266b5058

jbergstroem commented 2 years ago

(Checking the logic for building a docker image)

I would suggest decoupling auth/logging in to docker hub for testing if the container builds. I would do a separate action/ci job that only runs on tags and uploads instead.

chdsbd commented 2 years ago

@jbergstroem I like building the containers for every commit so that I can test any commit in a staging environment

jbergstroem commented 2 years ago

@jbergstroem I like building the containers for every commit so that I can test any commit in a staging environment

You mean pulling it manually? If so, ok, got it!

chdsbd commented 2 years ago

@jbergstroem I'm not sure why, but this change isn't passing the build.

Regarding the containers, yeah, I manually specify the SHA to deploy

jbergstroem commented 2 years ago

@jbergstroem I'm not sure why, but this change isn't passing the build.

Strange; it was all green yesterday. The failures I see right now seems docker auth related?

Edit: I see it now (bot_test). Will investigate.

jbergstroem commented 2 years ago

@chdsbd I was able to reproduce locally with python 3.7 (but not with 3.9 which was my homebrew default). I think you had it by updating ipdb but not updating the lockfile at the same time probably bit you. Will force push an update which should change lockfile.

~~Edit: gah, now I got bit too. I forgot to update the build dependency in pyproject.toml that tells the linter to update a newer poetry; which apparently doesn't get reflected in the lockfile. Will update cache as a separate commit and we can just remove it while considering landing. ~~

Edit 2: It was simpler than that. I didn't update all locations in .circleci/config.yml, which together with an outdated ipdb made it fail.

jbergstroem commented 2 years ago

@chdsbd there's a failed test due to outdated (?) fixtures:

______________________________ test_config_schema ______________________________

    def test_config_schema() -> None:
        """
        Although we don't use the config schema anywhere, it provides a form of
        documentation for the bot config.
        """
        schema_path = load_config_fixture("config-schema.json")
>       assert json.loads(V1.schema_json()) == json.loads(schema_path.read_text()), (
            "schema shouldn't change unexpectedly.\n"
            "Did you remember to run `poetry run kodiak gen-conf-json-schema > kodiak/test/fixtures/config/config-schema.json` in the `bot` directory?"
        )
E       AssertionError: schema shouldn't change unexpectedly.
E         Did you remember to run `poetry run kodiak gen-conf-json-schema > kodiak/test/fixtures/config/config-schema.json` in the `bot` directory?
E       assert {'definitions...e': 'V1', ...} == {'definitions...e': 'V1', ...}
E         Omitting 4 identical items, use -vv to show
E         Differing items:
E         {'definitions': {'Approve': {'properties': {'auto_approve_usernames': {'default': [], 'items': {'type': 'string'}, 'ti...|reserved|||:::', 'title': 'Blacklist Title Regex', 'type': 'string'}, ...}, 'title': 'Merge', 'type': 'object'}, ...}} != {'definitions': {'Approve': {'properties': {'auto_approve_usernames': {'default': [], 'items': {'type': 'string'}, 'ti... {'default': '', 'title': 'Cut Body Before', 'type': 'string'}, ...}, 'title': 'MergeMessage', 'type': 'object'}, ...}}
E         Use -v to get the full diff

kodiak/test_config.py:120: AssertionError

Let me know what you want me to do.

jbergstroem commented 2 years ago

soo.. this is getting a bit out of hand 😄 Should I venture down the rabbit hole of lint fixes?