search

chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.04k stars 63 forks source link

feat: prefix URLs with `PR-URL` #730

Closed jbergstroem closed 3 years ago

jbergstroem commented 3 years ago

When enabling include_pull_request_url (defaults to false), prefix the URL added to the commit body with PR-URL. This follows other trailer syntax such as Co-Authored-By: as well as the general recommendations by conventional commits footer best practices.

Not sure how to handle with the fact that this could be seen as SEMVER breaking; changing expectations of commit body and all..

References: https://github.com/chdsbd/kodiak/issues/671#issuecomment-858240918

netlify[bot] commented 3 years ago

👷 Deploy request for kodiak-dashboard-staging pending review. Visit the deploys page to approve it

🔨 Explore the source changes: a5af5915e1ae68d509b881b3c19925354087bda6

netlify[bot] commented 3 years ago

👷 Deploy request for kodiak-docs pending review. Visit the deploys page to approve it

🔨 Explore the source changes: a5af5915e1ae68d509b881b3c19925354087bda6

jbergstroem commented 3 years ago

(the typing-extensions package seems to have issues getting installed)

chdsbd commented 3 years ago

@jbergstroem Poetry is being a pain like normal. I'm going to try to resolve that and then I'll merge this in.

I'm fine with this change even if it is technically a breaking change

jbergstroem commented 3 years ago

@jbergstroem Poetry is being a pain like normal. I'm going to try to resolve that and then I'll merge this in.

I noticed. Happy to do some lifting here too; getting acquainted with it.

I'm fine with this change even if it is technically a breaking change

Ok! I will go after Reviewed-By next.