chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

Add option to hide status message when no automerge label #757

Closed paescuj closed 2 years ago

paescuj commented 2 years ago

I've tested this via a self hosted Kodiak instance:

First scenario:

  1. Create a PR (don't add automerge label)
  2. Verify the correct message (Ignored (no automerge label: ...) is shown on PR

Second scenario:

  1. Set missing_automerge_label_message to false
  2. Create a PR (don't add automerge label)
  3. Verify no message (Ignored (no automerge label: ...) is shown on PR

Third scenario (addressing https://github.com/chdsbd/kodiak/issues/747#issuecomment-958565441):

  1. Set missing_automerge_label_message to false
  2. Create a PR (add automerge label)
  3. Verify the correct message (merging PR (waiting for status checks ...) is shown on PR
  4. Remove automerge label before checks have been finished
  5. Verify the correct message (Ignored (no automerge label: ...) is shown on PR
netlify[bot] commented 2 years ago

👷 Deploy request for kodiak-dashboard-staging pending review. Visit the deploys page to approve it

🔨 Explore the source changes: c9b4045201d03c7a83d01a922269eb5b06dc3a04

netlify[bot] commented 2 years ago

👷 Deploy request for kodiak-docs pending review. Visit the deploys page to approve it

🔨 Explore the source changes: c9b4045201d03c7a83d01a922269eb5b06dc3a04

paescuj commented 2 years ago

This change looks great!

One minor suggestion about changing the config name

Thank you for your quick review!

I've updated the config name.