search

chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

cannot merge (missing required reviews) #784

Closed styfle closed 2 years ago

styfle commented 2 years ago

I've had few PRs that didn't merge even though CI completed required checks and I approved the PR.

Here's the most recent one I had to manually approve https://github.com/vercel/next.js/pull/33825

Kodiak said "cannot merge (missing required reviews)"

chdsbd commented 2 years ago

Thanks for the report! I'll take a look and get back to you

chdsbd commented 2 years ago

At 6:17pm ET, Kodiak set a status message on that PR of "🛑 cannot merge (missing required reviews)", but looking at the PR, the PR was approved as of 6:15pm ET.

My guess is there was some race condition or replication lag between GitHub web hooks for the review and the review status being available in the API

I'll keep looking into this.

styfle commented 2 years ago

I think this is a false alarm.

I remember now that I had to click the force merge checkbox as an admin.

So that must mean the way codeowners is configured is requiring more than one approval.

Sorry about the confusion 😅

chdsbd commented 2 years ago

Great news! Thanks for the update @styfle