search

chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

Repeated approval for self-hosted mode #793

Closed tamalsaha closed 2 years ago

tamalsaha commented 2 years ago

I am using kodiak self-hosted version on Heroku. I am using auto approve for username feature. But it seems that the bot keeps repeatedly approving the pr. Here is an example:

https://github.com/bytebuilders/CHANGELOG/pull/13

kodiak file: https://github.com/bytebuilders/CHANGELOG/blob/master/.github/.kodiak.toml

I am using Heroku $7 instance in case that matters. I wonder if there is some kind to delay/multiple delivery of webhook type thing is happening.

I wonder if you have any idea how to further debug this.

tamalsaha commented 2 years ago

All the recent deliveries seem to be successful.

Screen Shot 2022-03-09 at 9 36 49 PM
tamalsaha commented 2 years ago

I was seeing lots of connection failure errors from Redis. I have raised the Redis connection limits to 256. Not sure that was causing problem.

chdsbd commented 2 years ago

Hmmm. I'm not sure about why this is happening. I'd look in Sentry or the logs and see if anything sticks out.

In the hosted version of Kodiak I haven't had any issue with connection failures from Redis.

I'd try checking your Redis connection timeout settings

tamalsaha commented 2 years ago

I found the problem. I had an extra space in the GITHUB_APP_NAME config var. This will fails the https://github.com/chdsbd/kodiak/pull/260/files#diff-6439f535e235b8283601300f8da0eae3cf173e371c6cfae5d8e141a36c137773R257 . Now working as expected.

Thanks for your time and kodiak.