search

chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

Introduce `approve.auto_approve_labels` option #817

Closed paescuj closed 2 years ago

paescuj commented 2 years ago

Closes #554

Implemented as suggested by @chdsbd:

I think approve.auto_approve_labels and approve.auto_approve_usernames being separate such that one doesn't require the other would match the behavior of other configuration options in Kodiak.

Also fixing some lint errors & enhances developer experience (see commits).

netlify[bot] commented 2 years ago

Deploy request for kodiak-docs pending review.

Visit the deploys page to approve it

Name Link
Latest commit 54c6bd16535d840299665e7aa13d1e8acee76600
netlify[bot] commented 2 years ago

Deploy request for kodiak-dashboard-staging pending review.

Visit the deploys page to approve it

Name Link
Latest commit 54c6bd16535d840299665e7aa13d1e8acee76600
chdsbd commented 2 years ago

Thanks for the PR @paescuj! This looks great. Thanks for the documentation and tests. I'll look into merging this soon

paescuj commented 2 years ago

Thanks for the fast & positive feedback, @chdsbd! That's great!