chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

Support dependabot's new feature to bump multiple packages at once #844

Closed Maxim-Mazurok closed 1 year ago

Maxim-Mazurok commented 1 year ago

As you can see in https://github.com/Maxim-Mazurok/google-api-typings-generator/pull/722 It says:

Bumps jest and @types/jest. These dependencies needed to be updated together.

Since the title reads "Bump jest and @types/jest" without mentioning the versions, I assume that kodiak couldn't check the versions:

Dependency upgrade types are parsed from the pull request title and body.

I've been using versions = ["major", "minor", "patch"] now I'm trying to remove this to hopefully force it to skip version check and merge anything from dependabot.

chdsbd commented 1 year ago

Yeah, we should definitely add support for this. It seems like we could parse the pull request body to find the version information.

Maxim-Mazurok commented 1 year ago

Yeah, we should definitely add support for this. It seems like we could parse the pull request body to find the version information.

Removing the versions field didn't help to get it auto-merged.

I've set up action-add-labels to add automerge for debepdabot PRs as a temporary(?) mesure: https://github.com/Maxim-Mazurok/google-api-typings-generator/blob/master/.github/workflows/add-automerge-label.yml

sbdchd commented 1 year ago

Looking into this, we extract the version from renovate PR descriptions but don't for dependabot. Should be a straightforward fix!

chdsbd commented 1 year ago

I've deployed #845 which should fix this issue. Let me know if you have any trouble