chdsbd / kodiak

🔮 A bot to automatically update and merge GitHub PRs
https://kodiakhq.com
GNU Affero General Public License v3.0
1.03k stars 65 forks source link

health_check_interval is set to True, not number of seconds #880

Open androa opened 6 months ago

androa commented 6 months ago

The documentation of redis-py says health_check_interval is an int for the number of seconds between health checks or ping/pong.

https://github.com/chdsbd/kodiak/blob/729e64dbc1211117a1d83aaccc0bcbd0967e550a/bot/kodiak/redis_client.py#L22

I assume setting it to true would be the same as setting it to 1? Maybe 10, 30, or a configurable value would be better?

chdsbd commented 5 months ago

I'm open to PRs supporting configuration for this setting.

For what it's worth, this health check interval works in production, even if it is a little too frequent