search

cheahjs / TerrariaAPI-Server

Fork is now over at https://github.com/NyxStudios/TerrariaAPI-Server
https://tshock.co
32 stars 24 forks source link

Small Improvements #16

Closed CoderCow closed 11 years ago

CoderCow commented 11 years ago

Any idea why the diff of HandlerCollection.cs looks so messy? The file endings were all CRLF...

hakusaro commented 11 years ago

:+1:

hakusaro commented 11 years ago

Wait, no. We converted all of our line endings to CRLF. You shouldn't be sending us LF changes.

hakusaro commented 11 years ago

Or at least, I'm guessing you sent them since you just stated that "The file endings were all CRLF..."

CoderCow commented 11 years ago

They were on commit, I'm not sure what git might have changed them to because of the .gitattributes, as those made my local repo acting odd first: When I tried to commit the new .editorconfig with CRLF endings for example, it warned me by "Warning: CRLF will be replaced by LF".

My global settings are all default, except core.autocrlf = false.

Edit: Checked, everything should definitely be CRLF. Edit 2: Silly me, according to the .gitattributes the behaviour makes perfect sense.