search

cheahjs / TerrariaAPI-Server

Fork is now over at https://github.com/NyxStudios/TerrariaAPI-Server
https://tshock.co
32 stars 24 forks source link

Updates to certain packets #37

Closed QuiCM closed 10 years ago

QuiCM commented 10 years ago

1.2.3 comes with Terraria.ID.MessageIDs which contain a few packets and many named 'unknownx' where x is an integer. PacketTypes should probably reflect this

Packets changed: 4, 5, 10, 31, 32, 33, 34, 70, 71, 72, 73 Note that this means that TileKill doesn't seem to exist in known packets anymore, and has instead been replaced with 'ChestUpdate'. This could be part of what is causing problems 73 'count' does not seem to be used in the game, but it's in the class so I've added it

If this edit is acceptable, I'll go through the rest of TerrariaAPI-Server and TShock and change the packets to reflect these updated packets where necessary

Olink commented 10 years ago

Those enums were more for us internally to know what its doing....changing them would cause quite a few problems....ideally would be to change the ones that have bad names (see the chest packets) and add in the new ones.

Olink commented 10 years ago

Also count isnt a packet, its the number of packets, we dont need that.

QuiCM commented 10 years ago

Would you like me to continue and update the badly named ones? Alternatively we can wait until the Terraria devs complete their list (which it seems they plan on doing) and make changes relating to that

Olink commented 10 years ago

I suggest waiting.