search

cheahjs / TerrariaAPI-Server

Fork is now over at https://github.com/NyxStudios/TerrariaAPI-Server
https://tshock.co
32 stars 24 forks source link

Fix projectile exploit #38

Closed Simon311 closed 10 years ago

Simon311 commented 10 years ago

Projectile 109 Snow Ball - kills with PvP off

hakusaro commented 10 years ago

:thumbsup: if @Olink thinks this would solve that problem.

Simon311 commented 10 years ago

UPDATE: it doesn't seem to solve the issue However, it seems that the issue only occurs with TShock, with DisableSnowBalls = true

Olink commented 10 years ago

Is that present in vanilla?

Simon311 commented 10 years ago

However, it seems that the issue only occurs with TShock, with DisableSnowBalls = true

No, doesn't happen in Vanilla

Olink commented 10 years ago

Thats not what I asked. I asked if your addition is present in vanilla.

Simon311 commented 10 years ago

Like I said, it didn't work. And no, it is not present in Vanilla. Basically, this PR is garbage, sorry for wasting your time.

hakusaro commented 10 years ago

@Simon311 you should make an issue about this behavior then.

k0rd commented 10 years ago

why would you change ranged? setting it friendly (in addition to hostile, see boulders, ash balls, mud balls for examples...)) might produce the results you are looking for,

Olink commented 10 years ago

If it isnt in vanilla, it has no place in the Tsapi. We arent here to fix bugs that dont exist. The fact that this is a tshock bug means we are doing something naughty.