cheahjs / palworld-save-tools

Tools for converting Palworld .sav files to JSON and back
MIT License
767 stars 65 forks source link

Can't work on path that have Unicode character #93

Open LaoshuBaby opened 5 months ago

LaoshuBaby commented 5 months ago

Common issues before reporting

Have you modified the save files No

Have you tried the latest release Yes

Describe the bug Can't work on path that have Unicode character

D:\Git_Playground\palworld-save-tools>py convert.py "D:\Git_Playground\palworld-save-tools\新建文件夹\Level.sav"
D:\Git_Playground\palworld-save-tools\新建文件夹\Level.sav does not exist

D:\Git_Playground\palworld-save-tools>py convert.py "D:\Git_Playground\palworld-save-tools\sav\Level.sav"
Converting D:\Git_Playground\palworld-save-tools\sav\Level.sav to JSON, saving to D:\Git_Playground\palworld-save-tools\sav\Level.sav.json
Decompressing sav file
Loading GVAS file
Writing JSON to D:\Git_Playground\palworld-save-tools\sav\Level.sav.json

"新建文件夹(New Folder)" is the default name when creating a new folder using the Chinese Windows system, similar to "Untitled"

Copy of .sav or .sav.json files No save data related


Because this Issue does not involve the core functions of the converter, if you don't have time to fix it, just suggest users to use pure ASCII character paths in the README.

gamedazed commented 4 months ago

Hey, not sure if you've tested this since the bug report was made, but I just tested it with no issues (other than my terminal rendering the path with ?s :stuck_out_tongue_closed_eyes:) image