cheald / manticore

Manticore is a JRuby HTTP client built on the Apache HttpClient 4.x components
https://gitlab.com/cheald/manticore
MIT License
54 stars 34 forks source link

Refactor: import Java class(es) from package directly #90

Closed kares closed 3 years ago

kares commented 3 years ago

reviewed a few package imports to be explicit about the classes used, most interesting is the org.apache.http.conn.ssl - as seen previously - there are issues with the dependencies of org.apache.http.conn.ssl.SSLConnectionSocketFactory which lead to a NameError (not being able to load the class on some JDK setups).

with include_package such NameError gets lost as it is assumed to be caused by a Java ClassNotFoundException but that isn't necessarily always the case.

by explicitly importing the SSL classes used by manticore's client we should exhibit these failures early (at .rb load time).