Fix: don't override certificates with same subject

cheald / manticore

Manticore is a JRuby HTTP client built on the Apache HttpClient 4.x components

https://gitlab.com/cheald/manticore

MIT License

54 stars 34 forks source link

Fix: don't override certificates with same subject #93

Closed kares closed 3 years ago

kares commented 3 years ago

from https://github.com/cheald/manticore/pull/85:

When creating a truststore from a certificate bundle it may happen that two certificates will have the same getSubjectX500Principal, causing the first one to be replaced.

kares commented 3 years ago

Hey @olleolleolle I have rebased #85 off master, it's all :green_circle: as expected. The setCertificateEntry alias change should not cause any compatibility issues, it's really internal to the key-store. Any chance we get #85 merged?

olleolleolle commented 3 years ago

@kares Thanks for the double-check – I merged it as a "rebase".

:hearts: :yellow_heart: :green_heart: :blue_heart: :purple_heart:

olleolleolle commented 3 years ago

Fantastic, that means that we can close this Draft, now that I think of it!