search

cheald / manticore

Manticore is a JRuby HTTP client built on the Apache HttpClient 4.x components
https://gitlab.com/cheald/manticore
MIT License
54 stars 34 forks source link

[feat] set Java cause for ManticoreException types #96

Closed kares closed 3 years ago

kares commented 3 years ago

It's very annoying to rescue ManticoreException and have a nil cause despite these being caused by Java exceptions. Since Ruby can not fill the cause for us (due the way the mapping logic is laid out) let's set the cause manually.

cheald commented 3 years ago

Looks good! Thank you!