cheap-glitch / fretboarder

🎸 A web app to visualize scales, chords and arpeggios on all kinds of fretboards.
https://fretboarder.app
Mozilla Public License 2.0
100 stars 15 forks source link

accidental notes #13

Closed sugizo closed 10 months ago

sugizo commented 4 years ago

Description

note name in ./src/modules/music.js seems not standard for one note and the others (one note use flat (♭) and the rest use sharp (#) ) e.g.

    'Bb': 'B♭',
    'C#': 'C♯',
    'D#': 'D♯',
    'F#': 'F♯',
    'G#': 'G♯',

as a result, it also can't define tuning with A# tone in ./src/modules/music.js

better to make it standard, use all flat or all sharp and then have a button to make change for accidental sign some users's behaviour read conveniently with flat, some conveniently read with sharp

Implementation details

A#
C#
D#
F#
G#

when user click button it will change into

Bb
Db
Eb
Gb
Ab

or vice versa, thanks