Replace `null` with undefined/void

cheap-glitch / mi-cron

📆 A microscopic parser for standard cron expressions.

https://npm.im/@cheap-glitch/mi-cron

ISC License

18 stars 2 forks source link

Replace `null` with undefined/void #1

Closed fregante closed 3 years ago

fregante commented 3 years ago

https://github.com/sindresorhus/meta/issues/7

Thoughts?

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.53. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

cheap-glitch commented 3 years ago

I haven't got any strong opinions about this, so I'm okay to change it to undefined.

Plus since this was primarily made to be used by Refined GitHub, it makes sense to change it to whatever you think would be more convenient.

cheap-glitch commented 3 years ago

I'll hold off on releasing this for a few days. I documented the API in the readme, if you want any changes just ask.

notlmn commented 3 years ago

I was about to ask for chaining nextDate(), but I see that it is already available in other way https://github.com/cheap-glitch/mi-cron/commit/bb3d8e625c394026725af434a8347f917dac3c90.

Awesome work @cheap-glitch 🎉