search

cheatfate / nimcrypto

Nim cryptographic library
MIT License
189 stars 23 forks source link

Enable styleCheck:usages #53

Closed Menduist closed 1 year ago

cheatfate commented 2 years ago

I would recommend to stick with openarray to openArray rename only, all other renames (arguments, variables, constants) are not going to be accepted.

Menduist commented 2 years ago

I renamed arguments, variables & constants because they were used inconsistently and caused compilation error. I updated the code to remove some useless changes I did, let me know if it's ok

cheatfate commented 2 years ago

Public and private procedure names as well as variable name must not be changed.

Menduist commented 2 years ago

Then it won't compile, styleCheck applies to everything, not just public stuff

Menduist commented 1 year ago

Seems like #55 was enough, feel free to re-open & merge if you want checks to run as part of the CI