chebro / discord-voice-recorder

A nifty script that can pipe out audio from a discord voice channel to your local storage. A discord voice recorder!
MIT License
114 stars 38 forks source link

Possible to join Stage Channels? #17

Closed shelomito12 closed 3 years ago

shelomito12 commented 3 years ago

Hey thanks for this awesome bot... was wondering if maybe you could update the bot to be able to join Stage Channels.

Thanks

AlexIsOK commented 3 years ago

i made a fork which has a patch for this and some other minor issues, i'll be merging soon

shelomito12 commented 3 years ago

@AlexIsOK , I tried your fork and I confirm the bot can successfully record from a Stage Channel... but I didn't like the logging outputting lots/all information about my Discord server/channels:

Snippet:

$ node index.js

ONLINE

VoiceChannel {
  type: 'voice',
  deleted: false,
  id: '162014788620147868',
  name: 'Test Voice Channel',
  rawPosition: 3,
  parentID: '162014788620147868',
  permissionOverwrites: Collection(6) [Map] {
    '162014788620147868' => PermissionOverwrites {
      id: '162014788620147868',
      type: 'role',
      deny: [Permissions],
      allow: [Permissions]
    },
    '162014788620147868' => PermissionOverwrites {
      id: '162014788620147868',
      type: 'role',
      deny: [Permissions],
      allow: [Permissions]
    },
    '162014788620147868' => PermissionOverwrites {
      id: '162014788620147868',
      type: 'role',
      deny: [Permissions],
      allow: [Permissions]
    },
    '162014788620147868' => PermissionOverwrites {
      id: '162014788620147868',
      type: 'role',
      deny: [Permissions],
      allow: [Permissions]
    },
    '162014788620147868' => PermissionOverwrites {
      id: '162014788620147868',
      type: 'role',
      deny: [Permissions],
      allow: [Permissions]
    },
    '162014788620147868' => PermissionOverwrites {
      id: '162014788620147868',
      type: 'role',
      deny: [Permissions],
      allow: [Permissions]
    }
  },
  rtcRegion: null,
  bitrate: 64000,
  userLimit: 0,
  guild: <ref *1> Guild {
    members: GuildMemberManager {
      cacheType: [class Collection extends Collection],
      cache: [Collection [Map]],
      guild: [Circular *1]
    },
    channels: GuildChannelManager {
      cacheType: [class Collection extends Collection],
      cache: [Collection [Map]],
      guild: [Circular *1]
    },
    roles: RoleManager {
      cacheType: [class Collection extends Collection],
      cache: [Collection [Map]],
      guild: [Circular *1]
    },
    presences: PresenceManager {
      cacheType: [class Collection extends Collection],
      cache: Collection(0) [Map] {}
    },
    voiceStates: VoiceStateManager {
      cacheType: [class Collection extends Collection],
      cache: [Collection [Map]],
      guild: [Circular *1]
    },
... <clipped log>
shelomito12 commented 3 years ago

@AlexIsOK There is an issue when you have a text channel using the name #general and a Voice channel also using the name General (G is upper case). It seems your fork confuses these 2 and got this: image Note 1: I also tried with >enter General (with upper case G) and still same above issue. Note 2: This doesn't happen with @chebro repo

Then I tried a different Voice channel which name isn't the same as an existing text channel and then it worked.

AlexIsOK commented 3 years ago

forgot i left the logging there. i'll remove that and filter out text channels and categories

AlexIsOK commented 3 years ago

pushed, it should work now.

shelomito12 commented 3 years ago

Thanks @AlexIsOK! It's working fine now.