search

chec / cli

A command line interface for using the Chec API
https://chec.io
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

demo-store command should ask to confirm seeding #28

Closed robbieaverill closed 4 years ago

robbieaverill commented 4 years ago

If I were to set up multiple demo stores, I wouldn't necessarily want to have multiple sets of products seeded. If it were to ask to confirm whether I wanted this I could say no before it does this.

ScopeyNZ commented 4 years ago

Agreed. It would be nice to add a --skip-seed flag too.

robbieaverill commented 4 years ago

Yeah for sure - I think we should aim for every prompted option to be controllable with a flag too, in cases where people want to use it with no interaction

robbieaverill commented 4 years ago

@ricardodesimas also suggested that we could check for an existing product/category/etc before seeding to prevent double ups, which could also be an optional argument

rafaeelaudibert commented 4 years ago

Hey, I can definitely take a look at this! What are we going for now? (as there are some different ideas on the PR). What do you think about making this issue related to asking this new question during the creation?

We could create a different issue (and make it available through Hacktoberfest as well), to make the --skip-* flags

robbieaverill commented 4 years ago

Hey @rafaeelaudibert, that's a good idea, but I don't think having a separate issue would be useful here. The approach for this issue should be to ask to confirm whether you want to seed sample data, and the skip seed flag @ScopeyNZ suggested would take priority meaning we would not ask to confirm seeding because we know the answer is "no". Hope this is helpful!

rafaeelaudibert commented 4 years ago

Perfect, can go the way you suggested! Could you please assign this to me? Will probably have this sorted next week.

robbieaverill commented 4 years ago

Sure, thanks for contributing!

hashtag-incIude commented 4 years ago

add --skip-seed flag

robbieaverill commented 4 years ago

Thank you for your work on this @rafaeelaudibert

hashtag-incIude commented 4 years ago

Sir i am eligible for getting the swag. If yes how can I get it ..

On Fri, Oct 16, 2020, 12:10 AM Robbie Averill notifications@github.com wrote:

Thank you for your work on this @rafaeelaudibert https://github.com/rafaeelaudibert

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/chec/cli/issues/28#issuecomment-709518098, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRAQ7P3JWVK66FVJUT5OHLSK46ZLANCNFSM4JZDMNTA .

ScopeyNZ commented 4 years ago

Hi @hashtag-incIude. You have to make a pull request and have it merged for you to be eligible for swag. I can't see that you've raised any pull requests against any of our repos so unfortunately you're not eligible 😢

hashtag-incIude commented 4 years ago

Sir i have it now,can you please check it once.

On Fri, Oct 16, 2020 at 7:52 AM Guy Marriott notifications@github.com wrote:

Hi @hashtag-incIude https://github.com/hashtag-incIude. You have to make a pull request and have it merged for you to be eligible for swag. I can't see that you've raised any pull requests against any of our repos so unfortunately you're not eligible 😢

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chec/cli/issues/28#issuecomment-709690446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRAQ7K4NYSLHTEWCBZT35LSK6U6HANCNFSM4JZDMNTA .

hashtag-incIude commented 4 years ago

Sir I have done it now,can you please check it once.

On Fri, Oct 16, 2020 at 9:50 AM ANUKUL KUMAR anukulsingh2403@gmail.com wrote:

Sir i have it now,can you please check it once.

On Fri, Oct 16, 2020 at 7:52 AM Guy Marriott notifications@github.com wrote:

Hi @hashtag-incIude https://github.com/hashtag-incIude. You have to make a pull request and have it merged for you to be eligible for swag. I can't see that you've raised any pull requests against any of our repos so unfortunately you're not eligible 😢

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chec/cli/issues/28#issuecomment-709690446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJRAQ7K4NYSLHTEWCBZT35LSK6U6HANCNFSM4JZDMNTA .

ScopeyNZ commented 4 years ago

Hi @hashtag-incIude. Sorry, I can't find any pull request from you on any of our hacktoberfest repos. A comment on an issue isn't the kind of contribution we distribute swag for. If you make a pull request that is accepted and merged, then you can be eligible. Thanks for your interest!