chec / commercejs-nextjs-demo-store

Commerce demo store built for the Jamstack. Built with Commerce.js, Next.js, and can be one-click deployed to Netlify. Includes product catalog, customer login, categories, variants, cart, checkout, payments (Stripe) order confirmation, and printable receipts.
https://commercejs-demo-store.netlify.app/
BSD 3-Clause "New" or "Revised" License
1.07k stars 206 forks source link

[CHEC-382] - Feature/pdp #2

Closed jaepass closed 4 years ago

jaepass commented 4 years ago

Making this a draft PR as there are still some kinks to work out. Hoping to get all UI components working on PDP first to avoid a large PR, and leave cart functionalities to Cart issue in next PR.

Working/changes:

Not working/questions:

linear[bot] commented 4 years ago

CHEC-382 Individual product page

robbieaverill commented 4 years ago

can we keep the Shipping and Returns & Details as static data?

I think so

ScopeyNZ commented 4 years ago
  • can we keep the Shipping and Returns & Details as static data?

Sounds good to me.

The other thing mentioned in the linear issue is the two descriptions - do you want to sort that out too?

I'm happy to merge this if you want to push forward, and then we can do PRs for each individual thing, rather than having this huge thing that's changing. Sound good?

jaepass commented 4 years ago
  • can we keep the Shipping and Returns & Details as static data?

Sounds good to me.

The other thing mentioned in the linear issue is the two descriptions - do you want to sort that out too?

I'm happy to merge this if you want to push forward, and then we can do PRs for each individual thing, rather than having this huge thing that's changing. Sound good?

thanks Guy that sounds great if you're ok to merge then ill push on to the next thing! some of the issues involve quite a few files, should I be breaking larger issues those into sub issues?

jaepass commented 4 years ago

also i've connected the repo to Netlify but haven't built the project yet. Will wait until this is merged and will put up a live preview going forward

ScopeyNZ commented 4 years ago

Whatever makes sense Jaeriah. It doesn't usually matter how many files you touch in a PR, it just helps if the PR is focused on a clear (and small) goal, otherwise they blow up and include so much stuff that it's difficult to review.

jaepass commented 4 years ago

Whatever makes sense Jaeriah. It doesn't usually matter how many files you touch in a PR, it just helps if the PR is focused on a clear (and small) goal, otherwise they blow up and include so much stuff that it's difficult to review.

sounds good noted thanks Guy. will wait on your merge and jump on to the next thing

ScopeyNZ commented 4 years ago

Thank Jaeriah. I fixed up the Netlify stuff. Summary of what I did: