Closed jaepass closed 4 years ago
can we keep the Shipping and Returns & Details as static data?
I think so
- can we keep the Shipping and Returns & Details as static data?
Sounds good to me.
The other thing mentioned in the linear issue is the two descriptions - do you want to sort that out too?
I'm happy to merge this if you want to push forward, and then we can do PRs for each individual thing, rather than having this huge thing that's changing. Sound good?
- can we keep the Shipping and Returns & Details as static data?
Sounds good to me.
The other thing mentioned in the linear issue is the two descriptions - do you want to sort that out too?
I'm happy to merge this if you want to push forward, and then we can do PRs for each individual thing, rather than having this huge thing that's changing. Sound good?
thanks Guy that sounds great if you're ok to merge then ill push on to the next thing! some of the issues involve quite a few files, should I be breaking larger issues those into sub issues?
also i've connected the repo to Netlify but haven't built the project yet. Will wait until this is merged and will put up a live preview going forward
Whatever makes sense Jaeriah. It doesn't usually matter how many files you touch in a PR, it just helps if the PR is focused on a clear (and small) goal, otherwise they blow up and include so much stuff that it's difficult to review.
Whatever makes sense Jaeriah. It doesn't usually matter how many files you touch in a PR, it just helps if the PR is focused on a clear (and small) goal, otherwise they blow up and include so much stuff that it's difficult to review.
sounds good noted thanks Guy. will wait on your merge and jump on to the next thing
Thank Jaeriah. I fixed up the Netlify stuff. Summary of what I did:
package.json
that includes next export
- a01dba1yarn deploy
(what I added) - it was previously doing next-build
which didn't existdist
to out
- that's default for Next I think
Making this a draft PR as there are still some kinks to work out. Hoping to get all UI components working on PDP first to avoid a large PR, and leave cart functionalities to Cart issue in next PR.
Working/changes:
getStaticProps()
getStaticPaths()
at page levelProductHero
and moved the dynamic Product content intoProductDetails
, all other components on this page are rendered bypages/product/[permalink].js
. Alternatively,pages/product/[permalink].js
can be changed topages/product/[permalink]/index.js
variantSelector
loops through available variants and available options within variantproducts
in redux store.SuggestedProducts
same asProductRow
component rendering the latest 4 products. Or could alternatively render other products in same cat.Not working/questions:
onSelectVariant
toggling, need to tie the toggle or onSelectVariant to reflect price change