Netlify onboarding plugin not working

chec / commercejs-nextjs-demo-store

Commerce demo store built for the Jamstack. Built with Commerce.js, Next.js, and can be one-click deployed to Netlify. Includes product catalog, customer login, categories, variants, cart, checkout, payments (Stripe) order confirmation, and printable receipts.

https://commercejs-demo-store.netlify.app/

BSD 3-Clause "New" or "Revised" License

1.07k stars 206 forks source link

Netlify onboarding plugin not working #80

Closed jaepass closed 4 years ago

jaepass commented 4 years ago

Added onboarding plugin to Netlify config, tested and worked fine
Somehow regressed and now onboarding screen does not show extra template.environment property to input env var

jaepass commented 4 years ago

Raised an issue here https://github.com/jlengstorf/netlify-plugin-onboarding/issues/1

ScopeyNZ commented 4 years ago

I assume we'll need to update the plugin when it's fixed?

jaepass commented 4 years ago

heyhey Guy a patch was added and fixed now. no need for an update on our end. the plugin is now working as expected!

ScopeyNZ commented 4 years ago

Sure, but won't the yarn.lock be tied to the broken version?

ScopeyNZ commented 4 years ago

Nevermind, I was confused to how this works. It didn't require a change to the dependency, something on their servers. All good.

jaepass commented 4 years ago

Awesome thanks Guy, yea seemed like a real quick fix, they got on the issue today and patched it in a couple hours.