Revert "fix checkout bug where pages/checkout.js redirects to homepage on successful checkout"

chec / commercejs-nextjs-demo-store

Commerce demo store built for the Jamstack. Built with Commerce.js, Next.js, and can be one-click deployed to Netlify. Includes product catalog, customer login, categories, variants, cart, checkout, payments (Stripe) order confirmation, and printable receipts.

https://commercejs-demo-store.netlify.app/

BSD 3-Clause "New" or "Revised" License

1.07k stars 206 forks source link

Revert "fix checkout bug where pages/checkout.js redirects to homepage on successful checkout" #91

Closed john-raymon closed 4 years ago

john-raymon commented 4 years ago

Reverts chec/commercejs-nextjs-demo-store#90

ScopeyNZ commented 4 years ago

...???

john-raymon commented 4 years ago

@ScopeyNZ I thought I needed a revert.

ScopeyNZ commented 4 years ago

Why?

john-raymon commented 4 years ago

@ScopeyNZ

I merged my PR.

Got an email saying there's a vulnerability.

Assumed wrong that my pr was the issue.

So I reverted the merge, then merged again when I realized my thinking was wrong.

Clearly rookie mistake on my end.

ScopeyNZ commented 4 years ago

Ok. Let's revert the revert, as we're pretty happy with this PR. We've got a separate process to deal with automated vulnerability alerts in node packages.