Better error handling when categories are deleted in the backend

chec / commercejs-nextjs-demo-store

Commerce demo store built for the Jamstack. Built with Commerce.js, Next.js, and can be one-click deployed to Netlify. Includes product catalog, customer login, categories, variants, cart, checkout, payments (Stripe) order confirmation, and printable receipts.

https://commercejs-demo-store.netlify.app/

BSD 3-Clause "New" or "Revised" License

1.07k stars 206 forks source link

Better error handling when categories are deleted in the backend #98

Closed jaepass closed 4 years ago

jaepass commented 4 years ago

Scenario:

When a user clones the project, seeds the sample data and sets up the app locally, he/she deletes the sample categories
The hard coded categories data here https://github.com/chec/commercejs-nextjs-demo-store/blob/master/lib/collections.js does not match up and the UI cannot be rendered

Solutions:

Better error handling
Get rid of hardcoded collections data and somehow output dynamically or remove from UI where it is used in home page categories banner and sidebar in shop pages and pdp (added categories feature image and product count)

robbieaverill commented 4 years ago

Solutions sound great to me 👍

robbieaverill commented 4 years ago

Another scenario for this is when someone clones the project, changes to their own API key, but doesn't seed any data or set up any products/categories.

robbieaverill commented 4 years ago

Fixed with #105 for now. Ideally we stop relying on hard coded category/asset information in future, but no need to keep this issue open for that.