search

chec / ui-library

Chec UI library assets and components
https://chec-ui.netlify.app/
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

[Alert component] Make it undismissible by default #473

Open robbieaverill opened 3 years ago

robbieaverill commented 3 years ago

image image

This renders an alert which is dismissible, since I didn't tell it not to be, but the close button has no default handler. This feels strange to me, I think we should make it undismissible by default.

ScopeyNZ commented 3 years ago

Yeah good point. We can maybe be fancy here and use this.$listeners.close to figure it out.

Also, I notice that the click event is bound to the icon and not the button which is wrong, so we should fix that too.