search

checkdomain / Holiday

Check whether a date is a holiday
www.checkdomain.de
MIT License
49 stars 26 forks source link

Portugal Holidays #17

Closed Danubio closed 7 years ago

Danubio commented 7 years ago

The holidays listed are for the year 2017. We (Portuguese) disabled a few a couple of years back and we are re-enabling them little by little

FlorianKoerner commented 7 years ago

Looks good. Would you adding some tests? https://github.com/checkdomain/Holiday/tree/master/tests/Checkdomain/Holiday/Provider

FlorianKoerner commented 7 years ago

And could you please add support for 2013 - 2016? Example: https://github.com/jareis/Holiday/blob/master/lib/Checkdomain/Holiday/Provider/PT.php#L59

Danubio commented 7 years ago

Yes sure

Danubio commented 7 years ago

All done

FlorianKoerner commented 7 years ago

Thank you! 👍