test on php 7.2

[garak]

I got some test failing on php 7.2 Let's check if it's only a local problem...

[garak]

Well, that's weird, since my local installation of project is failing as follows. Should I open an issue? Or maybe I'm missing something?

2) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #9 ('2017-02-28', null, array('Carnaval'))
No Holiday found but assumed to find one on 2017-02-28
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

3) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #10 ('2018-02-13', null, array('Carnaval'))
No Holiday found but assumed to find one on 2018-02-13
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

4) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #11 ('2016-03-25', null, array('Sexta-Feira Santa'))
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Sexta-Feira Santa'
+'Data da Abolição da Escravidão no Ceará'

Holiday/test/Provider/AbstractTest.php:37

5) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #12 ('2017-04-14', null, array('Sexta-Feira Santa'))
No Holiday found but assumed to find one on 2017-04-14
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

6) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #13 ('2018-03-30', null, array('Sexta-Feira Santa'))
No Holiday found but assumed to find one on 2018-03-30
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

7) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #14 ('2016-05-26', null, array('Corpus Christi'))
No Holiday found but assumed to find one on 2016-05-26
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

8) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #15 ('2017-06-15', null, array('Corpus Christi'))
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Corpus Christi'
+'Aniversário do Estado'

Holiday/test/Provider/AbstractTest.php:37

9) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #16 ('2018-05-31', null, array('Corpus Christi'))
No Holiday found but assumed to find one on 2018-05-31
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

10) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #50 ('2016-02-09', 'Rio de Janeiro', array('Carnaval'))
No Holiday found but assumed to find one on 2016-02-09
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

11) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #51 ('2017-02-28', 'Rio de Janeiro', array('Carnaval'))
No Holiday found but assumed to find one on 2017-02-28
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

12) Checkdomain\Holiday\Provider\BRTest::testHolidays with data set #52 ('2018-02-13', 'Rio de Janeiro', array('Carnaval'))
No Holiday found but assumed to find one on 2018-02-13
Failed asserting that null is not null.

Holiday/test/Provider/AbstractTest.php:30

[hanzi]

It depends on your system timezone (fails with positive offset from UTC).

This should be fixed by #38