search

checkdomain / Holiday

Check whether a date is a holiday
www.checkdomain.de
MIT License
49 stars 27 forks source link

Add holidays for Reunion #46

Closed julienmru closed 4 years ago

julienmru commented 4 years ago

Please consider merging this PR to add support for Reunion holidays

wandersonwhcr commented 4 years ago

Is this a province or state from France?

If yes, IMHO, we must create or change FR class and include a state parameter, like BR or DE.

wandersonwhcr commented 4 years ago

Examples:

https://github.com/checkdomain/Holiday/blob/master/src/Provider/BR.php https://github.com/checkdomain/Holiday/blob/master/src/Provider/DE.php

julienmru commented 4 years ago

Dear @wandersonwhcr, it is an overseas territory, a part of France but with its own ISO country code, IDD, domain name extension, etc. It's located East coast of Madagascar.

When you ship to Reunion from other countries, you need to specify 'Reunion' as a country and not 'France'.

So I guess it's really up to your policy but most libraries handle Reunion as a specific country, eg. giggsey/libphonenumber-for-php.

wandersonwhcr commented 4 years ago

@julienmru TY