Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h, and removal of the conditional in the snprintf declaration in stdio_checked.h

checkedc / checkedc-fork

This was a fork of Checked C used from 2021-2024. The changes have been merged into the original Checked C repo.

Other

26 stars 3 forks source link

Fixes for errors in the "array_ptr" interfaces to some libc functions declared in checkedc_extensions.h, and removal of the conditional in the snprintf declaration in stdio_checked.h #455

Closed secure-sw-dev-bot closed 2 years ago

secure-sw-dev-bot commented 2 years ago

This issue was copied from https://github.com/microsoft/checkedc/issues/456

This PR contains fixes for issues #449 and #450. They are, in brief: 1) link-time errors caused by declaring strncmp_array_ptr as extern inline, 2) missing definition for snprintf_array_ptr, and 3) inconsistency between the second argument of snprintf (i.e. the argument n) and the bounds declaration for the first argument of snprintf (i.e., the argument s) when n == 0.

secure-sw-dev-bot commented 2 years ago

Comment from @mgrang:

Could you please add a title describing the changes?

secure-sw-dev-bot commented 2 years ago

Comment from @mattmccutchen-cci:

Ideally, the new PR title would encompass the removal of the conditional from snprintf (#450) as well as the checkedc_extensions.h changes (#449). Sulekha, would you be willing to change it?

secure-sw-dev-bot commented 2 years ago

Comment from @sulekhark:

Ideally, the new PR title would encompass the removal of the conditional from snprintf (#450) as well as the checkedc_extensions.h changes (#449). Sulekha, would you be willing to change it?

Yes, of course.