search

checkedc / checkedc-llvm-project

This was a fork of Checked C clang used from 2021-2024. The changes have been merged into the original Checked C clang repo, which is now at https://github.com/checkedc/checkedc-clang.
https://www.checkedc.org
13 stars 19 forks source link

CheckedCRewriter unit tests fail after CConv changes #847

Closed secure-sw-dev-bot closed 2 years ago

secure-sw-dev-bot commented 2 years ago

This issue was copied from https://github.com/microsoft/checkedc-clang/issues/851

After https://github.com/microsoft/checkedc-clang/pull/837 merged we see the following three unit tests failing intermittently only on Windows:

- test/CheckedCRewriter/global.c
- test/CheckedCRewriter/simple_locals.c
- test/CheckedCRewriter/basic_checks.c

At least test/CheckedCRewriter/global.c seems to fail always when run manually on Windows.

$ "cconv-standalone" "clang\test\CheckedCRewriter\global.c" "--"
# command stderr:
Assertion failed: getPiece(StartPiece).size() > NumBytes, file clang\lib\Rewrite\RewriteRope.cpp, line 380

In order to unblock our failing ADO builds we need to disable the above three tests. We can enable them when we have these fixed.

secure-sw-dev-bot commented 2 years ago

Comment from @mgrang:

PR to disable tests: https://github.com/microsoft/checkedc-clang/pull/854

secure-sw-dev-bot commented 2 years ago

Comment from @mgrang:

I see that these tests have been enabled by the 3C team and they are passing. I will go ahead and close this bug as it is no longer relevant.