checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

Can no longer access iframes #106

Closed jamieni closed 4 years ago

jamieni commented 4 years ago

Because of the removal of "permissions": ["*://*/"] in manifest.json, the extension can no longer access iframes.

maxigimenez commented 4 years ago

Thanks for reporting this @jamieni. Can you describe in what scenario are you hitting this issue? I just try it here https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select and I'm able to generate code using the DOM of the iframe on the right.

jamieni commented 4 years ago

Hi @maxigimenez, the scenario is when the iframe has a different base url than the original url. i.e. original url: abc.com iframe url: abc-def.com

maxigimenez commented 4 years ago

Thanks for the clarification @jamieni, just tested your PR, and looks good