checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

feat: able to specify custom key for input record #111

Closed mikedidomizio closed 3 years ago

mikedidomizio commented 3 years ago

Pull Request Template

Description

Added the ability to change the keyboard command for recording input changes. By default this is TAB. There are a few closed issues that had discussion about how to remedy the tabbing and losing focus, but no solution.

This change allows users to change what key to finish input record to what they want. For instance I found SHIFT to be a better key.

This adds a button in the options menu, where a user clicks it and the extension listens for the next key down event. I'm not a big fan of displaying the key code instead of the actual key but I didn't want to store both as one is only for display purposes.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Ran the entire test suite that's provided and added unit tests to cover the new changes.

Checklist:

tnolet commented 3 years ago

@mikedidomizio thanks for supplying this PR. We will review ASAP!

maxigimenez commented 3 years ago

LGTM 👍 , thanks for contributing @mikedidomizio!