checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.

https://checklyhq.com/headless-recorder

MIT License

15.03k stars 722 forks source link

fix escaping of backslash in selector #126

Closed honey-dip closed 3 years ago

honey-dip commented 3 years ago

Pull Request Template

Description

This patch fixes CodeGenerator.__parseEvents so that it works with backslash within selector. (issue: #110 )

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

New test code was added for this change.

Checklist:

[x] My code follows the style guidelines of this project. npm run lint passes with no errors.
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes. npm run test passes with no errors.

ianaya89 commented 3 years ago

@honey-dip thanks a lot for your contribution. I will be testing it and get back to you soon 💯

ianaya89 commented 3 years ago

@honey-dip this is working fine and will be part of our next release. Thanks again for your contribution 👌