Use alt-k as shortcut as ctrl-k is already taken in the browser by ch…

dolfje commented 2 years ago

Description

When I'm trying to type ctrl-k to hide the overlay, I'm going into the google search functionality of Chrome. So I have rebound all the shortcuts with alt instead of ctrl.

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

[x] My code follows the style guidelines of this project. npm run lint passes with no errors.
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes. npm run test passes with no errors.

ianaya89 commented 2 years ago

Hi @dolfje, thanks a lot for all your hard work on this project. 👏 I will be reviewing all the PR's you opened and get back as soon as possible.

ianaya89 commented 2 years ago

@dolfje Good catch on this! I am wondering if we should replace (ctrl + k) with (ctrl + shift + K) and keep using ctrl as target key. Or do you think will be better to migrate to alt?

dolfje commented 2 years ago

Don't have any preference for alt. ctrl +shitf is also an option

ianaya89 commented 2 years ago

@dolfje Could you change it to ctrl + shift + K?

checkly / headless-recorder