search

checkly / headless-recorder

Chrome extension that records your browser interactions and generates a Playwright or Puppeteer script.
https://checklyhq.com/headless-recorder
MIT License
15.03k stars 722 forks source link

Generated code readability and reusability improvement #224

Closed vanetreg closed 1 year ago

vanetreg commented 1 year ago

I have an improvement suggestion regarding generated codes: instead of using repeatedly codes like:

await page.waitForSelector('veryLongStringRepeated');
await page.click('veryLongStringRepeated');

something like:

let activeSelector = 'veryLongStringRepeated';
waitForAndClickActiveSelector(activeSelector);

would improve code reusability and readability.

ASISBusiness commented 1 year ago

I have an improvement suggestion regarding generated codes:

instead of using repeatedly codes like:


await page.waitForSelector(veryLongStringRepeated);

await page.click(veryLongStringRepeated);

something like:


activeSelector = 'veryLongStringRepeated;

waitForAndClickActiveSelector(activeSelector);

would improve code reusability and readability.

CASABECI commented 1 year ago

I have an improvement suggestion regarding generated codes: instead of using repeatedly codes like:

await page.waitForSelector(veryLongStringRepeated);
await page.click(veryLongStringRepeated);

something like:

activeSelector = 'veryLongStringRepeated;
waitForAndClickActiveSelector(activeSelector);

would improve code reusability and readability.

ianaya89 commented 1 year ago

https://github.com/checkly/headless-recorder/issues/232